Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pkg:mix dependency #3053

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Add pkg:mix dependency #3053

merged 4 commits into from
Sep 25, 2024

Conversation

craiglabenz
Copy link
Contributor

Adds mix dependency

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 10, 2024 •
edited
Loading

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️ 
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/samples/lib/brick_breaker.dart
pkgs/samples/lib/default_dart.dart
pkgs/samples/lib/default_flutter.dart
pkgs/samples/lib/fibonacci.dart
pkgs/samples/lib/google_ai.dart
pkgs/samples/lib/hello_world.dart
pkgs/samples/lib/main.dart
pkgs/samples/lib/sunflower.dart
pkgs/samples/tool/samples.dart
Package publish validation ✔️
Package Version Status

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@craiglabenz
Copy link
Contributor Author

craiglabenz commented Sep 10, 2024 •
edited
Loading

It seems I added mix to the wrong pubspec file, as it depends on Flutter but dart_services apparently does not

@craiglabenz craiglabenz mentioned this pull request Sep 10, 2024
Open
parlough
parlough approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@parlough parlough left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After chatting separately, I went ahead and added package:mix to the template and regenerated the deps files.

Looks good to me assuming @johnpryan is ok with the additional package support :)

@parlough parlough requested a review from johnpryan September 10, 2024 21:38
johnpryan
johnpryan approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@johnpryan johnpryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'm not too familiar with how mix uses package:build - do we have a sample app we can use to test and verify that the core functionality works?

@johnpryan johnpryan merged commit 7b4c8be into dart-lang:main Sep 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parlough parlough parlough approved these changes

@johnpryan johnpryan johnpryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@craiglabenz @johnpryan @parlough